Respect --title and --body in pr create web mode
#11500
Draft
+364
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak K. Shandiz <babakks@github.com>
…r create --web` Signed-off-by: Babak K. Shandiz <babakks@github.com>
… create --web` Signed-off-by: Babak K. Shandiz <babakks@github.com>
--title and --body in pr create web mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10527
The PR is still a draft.
As of now, acceptance tests for
pr createin web mode (Seepr-create-web*.txtarfiles underacceptance/testdata/pr) are added. These tests cover the currently working combinations of options (i.e. working as expected). Test cases for other combinations that do not behave as expected are added but commented out in the test files.So, the next step is to fix the
pr createimplementation to make it pass the rest of the test cases.Things confirmed so far:
--filland--fill-firstoptions do not respect--title,--body, or--body-fileoptions.--fill-verbosedoes not work in Web mode.