src/services/listener_baileys.ts (1)

92-94: Use optional chaining for safer key access.

The condition can be simplified using optional chaining, which is safer and more concise.

Apply this diff:

-if (i.key && i.key.id) {
+if (i.key?.id) {

🧰 Tools

🪛 Biome (1.9.4)

[error] 92-92: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

src/services/data_store_redis.ts (1)

71-85: Add error handling for contact operations.

The contact management methods should handle potential errors when converting IDs or accessing undefined properties.

Apply this diff:

 store.setContact = async (contact: Partial<Contact>) => {
+  if (!contact.id && !contact.lid) {
+    throw new Error('Contact ID or LID is required')
+  }
   const id =  jidToPhoneNumber(contact.id || contact.lid)
   const newData: Partial<Contact> = {}
   if (contact.name) {
     newData.name = contact.name
   }
   if (contact.verifiedName) {
     newData.verifiedName = contact.verifiedName
   }
   return setContact(phone, id, newData)
 }
 store.getContact = async (id: string) => {
+  if (!id) {
+    throw new Error('Contact ID is required')
+  }
   const newId =  jidToPhoneNumber(id)
   return getContact(phone, newId)
 }

src/services/data_store_file.ts (2)

111-118: Add type safety to contacts event handler.

The event handler could benefit from explicit type annotations and error handling.

Apply this diff:

-ev.on('contacts.upsert', async (contacts: Contact[]) => {
+ev.on('contacts.upsert', async (contacts: readonly Contact[]) => {
   logger.debug('contacts.upsert %s', phone, JSON.stringify(contacts))
   const { saveProfilePicture } = mediaStore
-  await Promise.all(contacts.map(async (c) => {
+  await Promise.all(contacts.map(async (c: Contact) => {
+    try {
       await dataStore.setContact(c)
       return saveProfilePicture(c)
+    } catch (error) {
+      logger.error('Failed to process contact:', error)
+    }
     })
   )
 })

---

129-143: Improve type safety in contact management methods.

The contact management methods could benefit from stronger type checking and error handling.

Apply this diff:

 dataStore.setContact = async (contact: Partial<Contact>) => {
+  if (!contact.id && !contact.lid) {
+    throw new Error('Contact ID or LID is required')
+  }
   const id =  jidToPhoneNumber(contact.id || contact.lid)
   const newData: Partial<Contact> = {}
   if (contact.name) {
     newData.name = contact.name
   }
   if (contact.verifiedName) {
     newData.verifiedName = contact.verifiedName
   }
+  if (!dataStore.contacts) {
+    dataStore.contacts = {}
+  }
   dataStore.contacts[id]  = { ...(dataStore.contacts[id] || {}), ...newData }
 }
 dataStore.getContact = async (id: string) => {
+  if (!id) {
+    throw new Error('Contact ID is required')
+  }
   const newId =  jidToPhoneNumber(id)
+  if (!dataStore.contacts) {
+    return undefined
+  }
   return dataStore.contacts[newId]
 }

src/services/redis.ts (1)

235-239: Consider adding TTL for contact data.

The setContact function correctly merges existing and new contact data. However, consider adding a TTL to prevent stale contact data from persisting indefinitely.

Apply this diff to add TTL:

-  await client.set(key, JSON.stringify({ ...currentContact, ...(contact || {} )}))
+  await client.set(key, JSON.stringify({ ...currentContact, ...(contact || {} )}), { EX: DATA_TTL })

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro