Skip to content

Conversation

@larabr
Copy link
Contributor

@larabr larabr commented Nov 4, 2025

Fix #1687 .

Diff in the generated index.js:

1a2
> var __defNormalProp = (obj, key, value) => key in obj ? __defProp(obj, key, { enumerable: true, configurable: true, writable: true, value }) : obj[key] = value;
6a8
> var __publicField = (obj, key, value) => __defNormalProp(obj, typeof key !== "symbol" ? key + "" : key, value);
146,156c148
< var AssertionError = class _AssertionError extends Error {
<   static {
<     __name(this, "AssertionError");
<   }
<   message;
<   get name() {
<     return "AssertionError";
<   }
<   get ok() {
<     return false;
<   }
---
> var _AssertionError = class _AssertionError extends Error {
158a151
>     __publicField(this, "message");
167a161,166
>   }
>   get name() {
>     return "AssertionError";
>   }
>   get ok() {
>     return false;
178a178,179
> __name(_AssertionError, "AssertionError");
> var AssertionError = _AssertionError;
1365,1370c1366
< var Assertion = class _Assertion {
<   static {
<     __name(this, "Assertion");
<   }
<   /** @type {{}} */
<   __flags = {};
---
> var _Assertion = class _Assertion {
1406a1403,1404
>     /** @type {{}} */
>     __publicField(this, "__flags", {});
1541a1540,1541
> __name(_Assertion, "Assertion");
> var Assertion = _Assertion;
1545,1548c1545
< var PluginEvent = class extends Event {
<   static {
<     __name(this, "PluginEvent");
<   }
---
> var _PluginEvent = class _PluginEvent extends Event {
1554a1552,1553
> __name(_PluginEvent, "PluginEvent");
> var PluginEvent = _PluginEvent;
1776,1779c1775
< var PluginAddChainableMethodEvent = class extends PluginEvent {
<   static {
<     __name(this, "PluginAddChainableMethodEvent");
<   }
---
> var _PluginAddChainableMethodEvent = class _PluginAddChainableMethodEvent extends PluginEvent {
1784a1781,1782
> __name(_PluginAddChainableMethodEvent, "PluginAddChainableMethodEvent");
> var PluginAddChainableMethodEvent = _PluginAddChainableMethodEvent;
4419c4417
< */

@43081j
Copy link
Contributor

43081j commented Nov 11, 2025

good catch!

makes sense to me 👍

@43081j 43081j merged commit 110a1ea into chaijs:main Nov 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Safari versions below v16.4 are unsupported

2 participants