Skip to content

Conversation

@ttodua
Copy link
Member

@ttodua ttodua commented Nov 25, 2025

we are re-creating a dict endlessly, there is some improvement if we do that once.

image

@ttodua ttodua marked this pull request as ready for review November 25, 2025 17:42
@carlosmiei
Copy link
Collaborator

@ttodua The thing, let's say a user copies this.options from one exchange to the other (to avoid reloading market/scurrencies/options/etc) we would create a weird scenarion binding methods from a different instance .

@ttodua
Copy link
Member Author

ttodua commented Dec 5, 2025

@ttodua The thing, let's say a user copies this.options from one exchange to the other (to avoid reloading market/scurrencies/options/etc) we would create a weird scenarion binding methods from a different instance .

for that (and many other reasons) I was always pushing the idea to have this.temporaryDict for instance-scope variables, but you were against it :))

@ttodua
Copy link
Member Author

ttodua commented Dec 5, 2025

moreover, if your argument holds (and we expect users to copy options), then right bcz of that we should actually avoid using .options for storing instance wide variables or temporary calculated things , and instead implement the separate container

@ttodua ttodua closed this Dec 16, 2025
@ttodua ttodua reopened this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants