-
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: added matplotlib support
#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! Great stuff! Good idea to port the I would like to exchange thoughts about findability. Having a separate repo for matplotlib is nice, because in the first instance I don't think people expect a As to (some) of your notes:
For me it's fine to put my name into e.g. the Thanks to section, mentioning the matplotlib part.
As far as I see, there is only a README for this repo, same for mine. An option could be to simply put the contents of my README to this one, as a separate matplotlib section. I think I would prefer that to putting it behind an extra click (e.g. in a wiki or so), because now people can find catppuccin/matplotlib and directly have a bit of example code and are ready to go. This was my intention, to directly show it is easy to use, so people will actually use it. What I mentioned before could also be an option: to make |
|
Hi there,
EDIT: It appears there is a Pages workflow there, but it doesn't generate a website yet, only the CSS for the 4 flavors. Yet, it shouldn't be that difficult to add the docs generation to that one. Happy to give it a go after this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late reply, busy times...
Looks great! Very neatly done and makes a lot of sense to include the matplotlib functionality likes this.
I suppose this is anyway not really for me to approve/merge, so I will leave that to others.
Once this gets merged, I will update the catppuccin/matplotlib package appropriately with deprecation, and a link to this repo in its README.
Documentation also sounds good, I can help out there if you want. The original README I think contains enough 'quick' examples that get people started. It would be nice to have something like that, so that people can use it rightaway.
|
your review & approval is very much appreciated @brambozz, thank you! |
backwardspy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your hard work on this PR! i think it looks good, just one issue to clear up and then we should be good to merge this in.
|
The PR catppuccin/matplotlib#3 on the other repo introduces a deprecation warning and redirects the users to this repo. |
|
huge thanks to the both of you @brambozz and @miloth for your work on the matplotlib port and on bringing it into this repo. i've credited you both in the readme. |
Hi there, I was looking at this repo and the sister on concerning
matplotlib. I saw that there is this outstanding issue: catppuccin/matplotlib#2.This PR aims at solving that. Looking at the repo structures, I believe they could live as one, rather than two separates. I checked it with
ruff,mypyandpytest. It should be alright.Main changes:
matplotlibfunctionalities.PALETTEobject.matplotlibis in the modspace (usingimportlib).matplotliblibrary.numpyfunctions.subprocesscall toruffin the build script for formatting the autogenerated file with the palettes.py.typedmarker to the repo to identify it as typed formypyusage in packages that use this as a dependency.poetryconfig to have the virtual environment generated locally in the.venvfolder in the root of the project.Notes:
README.matplotlibin an "easy" way to thetoml, I removed 3.8 from the supporte Python versions, since it'll be EOL in just a few months. It could be made to work, but I don't think it is worth for the little time 3.8 is supported.