Include columnOffset for jest Script creation #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
That's the reason I still use the old debug adapter as opposed to the one used in VSCode. It would be great if Jest could fix that with your PR. |
Contributor
Author
|
fixed in jest instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Jest compiles a file it does not forward the size of the module wrapper to node. This causes issue in the node debugger source map logic. As it cannot resolve the source file as the filesystem contains different code then the compiled Script. By adding the offset the contents match up again and the editor will not open an read only window anymore.
Using the normal Jest babel configuration breaks a lot of debugging information all values on hover and inside the debug console are not the actual value they should be. Which means that it is not possible to copy a line from the source file and run it directly in the debug console. As the moment a property is selected the root value has become the value of the property.
Also tried to make a PR to Jest directly, but not certain about the Corporate relation between SAP and Facebook. jestjs/jest#14148