[snap] Migrate to snap base to core24 #4593
Open
+16
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requirement for this feature was not being met as it requires GLib 2.84 and the core22 only has 2.72. The core24 snap base uses a newer version of gcc which likely has stricter compiler warnings and causes QEMU build failures in the snap.
Need to explicitly install gtkmm on core24
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4593 +/- ##
==========================================
+ Coverage 87.18% 87.26% +0.08%
==========================================
Files 247 247
Lines 14273 14173 -100
==========================================
- Hits 12443 12366 -77
+ Misses 1830 1807 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Included in the gnome extension already
199d208 to
08c2fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the snap base of the Multipass snap from core22 to core24.
Necessary and relevant changes are grouped together in commits with the reasoning explained in the commit body.
MULTI-2431