close dead connections even if they have active subscriptions#438
Open
tharu-jwd wants to merge 3 commits intocameri:mainfrom
Open
close dead connections even if they have active subscriptions#438tharu-jwd wants to merge 3 commits intocameri:mainfrom
tharu-jwd wants to merge 3 commits intocameri:mainfrom
Conversation
Owner
|
@tharu-jwd Please address failing ci checks |
There was a problem hiding this comment.
Pull request overview
Fixes a WebSocket heartbeat cleanup bug where dead connections with active subscriptions were never terminated, causing ongoing pings, event matching work, and memory growth.
Changes:
- Remove the
!this.subscriptions.sizeguard so pong timeouts close dead clients even when they have active subscriptions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
131
to
135
| public onHeartbeat(): void { | ||
| if (!this.alive && !this.subscriptions.size) { | ||
| if (!this.alive) { | ||
| console.error(`web-socket-adapter: pong timeout for client ${this.clientId} (${this.getClientAddress()})`) | ||
| this.client.close() | ||
| return |
Owner
|
@tharu-jwd commits must follow the conventional commits spec, please rebase and update your commit messages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The heartbeat was skipping termination for dead clients that had active subscriptions. Removed
!this.subscriptions.sizeguard fromonHeartbeat()as the solution.Related Issue
Fixes #427
Motivation and Context
Dead clients with subscriptions were kept alive forever. Server kept pinging them, matching events against their filters, leaking memory.
How Has This Been Tested?
Manually connected a client, sent a REQ, killed it abruptly, confirmed the server closes it on the next heartbeat cycle instead of continuing to ping.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: