Skip to content

I worked around not bundle sources when you set browseField false. #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
toshiyuki-rs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

I worked around not bundle sources when you set browseField false. #1959

toshiyuki-rs wants to merge 1 commit into from
+5 −4

Conversation

@toshiyuki-rs
Copy link

@toshiyuki-rs toshiyuki-rs commented Apr 15, 2020

It was caused by injecting require('process') line, even if you
set browseField false

fix #1835

@toshiyuki-rs
I worked around not bundle sources when you set browseField false.
3d1ac1f 
It was caused by injecting `require('process')` line, even if you
set browseField false

fix browserify#1835
@ljharb
Copy link
Member

ljharb commented Apr 17, 2020

This would need a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error when browserField: false and process is used

2 participants

@toshiyuki-rs @ljharb