fix: add exception to logger context in SqsConsumer #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the exception to the context will make sure that stack traces are visible in tools like Sentry when errors occur while processing messages. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
3935be9 to
ec19aed
Compare
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Adding the exception to the context will make sure that stack traces are visible in tools like Sentry when errors occur while processing messages. Previously, when logging the exception message, the full exception object with stack trace was not included in the context, which made debugging more difficult.
Changes
SqsConsumer::handleSqs()to pass exception objects in the logger context when logging exception messages$this->logger->error($exception)to$this->logger->error($exception->getMessage(), ['exception' => $exception])$this->logger->error($exception->getMessage())to$this->logger->error($exception->getMessage(), ['exception' => $exception])SQS record with id "%s" failed to be processed...) unchanged🤖 Generated with Claude Code