Refactor to a single layer #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
commented
May 24, 2025
mnapoli
commented
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an exploration for Bref v3: replace the 3 types of layers (function, fpm, console) with a single layer and single Docker image.
(actually to be clear: one per PHP version)
That would simplify and reduce the layers we have to publish and maintain.
Layers today are already very similar, most of the difference in logic happens in the Bref codebase already. So the main difference with today would be that we'd include
php-fpmin the function layer.From a user's perspective, there wouldn't really be a visible change: the
serverless.ymlconfig would stay the same, it's just that under the hood Bref would include the same layer every time.Related to brefphp/bref#1950