Skip to content

Add GPS DOP debug #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2022
Merged

Add GPS DOP debug #605

merged 1 commit into from
Nov 5, 2022

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Oct 24, 2022

Adds GPD_DOP debug

betaflight/betaflight#11912

@haslinghuis haslinghuis added this to the 3.7.0 milestone Oct 24, 2022
@haslinghuis haslinghuis self-assigned this Oct 24, 2022
@github-actions

This comment has been minimized.

Sign in to view
KarateBrot
KarateBrot requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@KarateBrot KarateBrot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Can we scale down the displayed DOP values by 100? (1 decimal place)
(They get multiplied by 100 in BF because they are originally float values).

@blckmn
Copy link
Member

blckmn commented Oct 24, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis force-pushed the add-gps-dop-debug branch 2 times, most recently from 82d659b to 4e5941e Compare October 24, 2022 22:41
@github-actions

This comment has been minimized.

Sign in to view
KarateBrot
KarateBrot requested changes Oct 24, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Oct 25, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis mentioned this pull request Nov 2, 2022
Merged
@haslinghuis haslinghuis merged commit 201f76b into betaflight:master Nov 5, 2022
@haslinghuis haslinghuis deleted the add-gps-dop-debug branch November 5, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

Assignees

@haslinghuis haslinghuis

Labels

Ready to merge RN: IMPROVEMENT

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@haslinghuis @blckmn @ctzsnooze @KarateBrot