Skip to content

fix issue #425 -- fix export video stuck calculating if craft/stick size = 0 #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2022
Merged

fix issue #425 -- fix export video stuck calculating if craft/stick size = 0 #586

merged 1 commit into from
Jun 24, 2022

Conversation

@njdro
Copy link

@njdro njdro commented Jun 23, 2022 •
edited
Loading

Co-authored-by: haslinghuis mark@numloq.nl

@haslinghuis
Copy link
Member

haslinghuis commented Jun 23, 2022

Is there a reason we need craft-size of 0%

Otherwise we should just limit range here by setting min to 1:

blackbox-log-viewer/index.html

Line 2847 in 64abeb7

<input name="craft-size" type="number" step="1" min="0" max="100"

@njdro
Copy link
Author

njdro commented Jun 23, 2022

i set it 0% to export video without displaying them; however, toggling the render "off" is just as effective.

haslinghuis
haslinghuis reviewed Jun 23, 2022
View reviewed changes
haslinghuis
haslinghuis requested changes Jun 23, 2022
View reviewed changes
@haslinghuis
Copy link
Member

haslinghuis commented Jun 23, 2022

Please amend the PR without creating another commit - or squash afterwards

@haslinghuis haslinghuis linked an issue Jun 23, 2022 that may be closed by this pull request
bug: export video stuck calculating if craft:size or stick:size set to 0% #425
Closed
@haslinghuis haslinghuis assigned njdro and unassigned njdro Jun 23, 2022
@nerdCopter nerdCopter force-pushed the 20220613_fix_issue_425 branch from a0a3de3 to 5b4eed4 Compare June 23, 2022 19:22
@nerdCopter nerdCopter force-pushed the 20220613_fix_issue_425 branch from 5b4eed4 to 9eaa3b6 Compare June 23, 2022 19:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to the 3.7.0 milestone Jun 23, 2022
@blckmn
Copy link
Member

blckmn commented Jun 23, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 1fd3922 into betaflight:master Jun 24, 2022
@nerdCopter nerdCopter deleted the 20220613_fix_issue_425 branch January 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@njdro njdro

Labels

bugfix

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

bug: export video stuck calculating if craft:size or stick:size set to 0%

4 participants

@njdro @haslinghuis @blckmn @nerdCopter