Skip to content

Update azure windows image #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2021
Merged

Update azure windows image #543

merged 1 commit into from
Nov 28, 2021

Conversation

@asizon
Copy link
Member

@asizon asizon commented Nov 6, 2021

Updated windows image to windows-2022 like betaflight/betaflight-configurator#2650

@asizon asizon self-assigned this Nov 6, 2021
@asizon asizon added this to the 3.6.0 milestone Nov 6, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member

blckmn commented Nov 25, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@ctzsnooze
Copy link
Member

ctzsnooze commented Nov 26, 2021

Hi Asizon - what is the improvement we get with this? What testing is required?

@asizon
Copy link
Member Author

asizon commented Nov 26, 2021

@ctzsnooze hello, no testing needed, is tested via azure pipelines. Windows server 2016 is already outdated from 15 November, this pr updates azure used virtual machine inage to windows server 2022.

@haslinghuis haslinghuis merged commit 9c38741 into betaflight:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

+1 more reviewer

@DusKing1 DusKing1 DusKing1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@asizon asizon

Labels

build system improvement RN: IMPROVEMENT

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@asizon @blckmn @ctzsnooze @haslinghuis @DusKing1