Use nw window and open links in new window #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d74298 to
7705ca6
Compare
mikeller
reviewed
Jul 5, 2020
| "version": "3.5.0", | ||
| "main": "main_nwjs.html", | ||
| "bg-script": "background.js", | ||
| "main": "index.html", |
Member
There was a problem hiding this comment.
Do we need "chromium-args" : "--disable-features=nw2" here?
Member
Author
There was a problem hiding this comment.
It seems that not. If I remember correctly, we added this to the Configurator because it had problems opening/saving files to disk. The Blackbox must use something different because it seems to be working. At some moment we need to revisit the Configurator part.
|
Kudos, SonarCloud Quality Gate passed!
|
mikeller
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be in the same line that betaflight/betaflight-configurator#1982
Maintaining the Chrome version produces confuse code. I've tested it under NW in Windows, and did some tests too under Chrome in Windows. All seems to work, but who knows...