Skip to content

Make range json serializable #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
belamov merged 3 commits into from
Mar 30, 2025
Merged

Make range json serializable #33

belamov merged 3 commits into from
Mar 30, 2025

Conversation

@vatsake
Copy link
Contributor

@vatsake vatsake commented Mar 21, 2025 •
edited
Loading

Made range json serializable. Not sure if the format is ok, but atleast it won't be empty now.

For example model:
image
will become:
image
After change:
image

$Model->toJson();
//or 
json_encode($Model);

@belamov belamov self-requested a review March 21, 2025 17:43
belamov
belamov requested changes Mar 21, 2025
View reviewed changes
Copy link
Owner

@belamov belamov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, thanks for your contribution, this is useful)
can you please add some tests for json seralization as well?

@vatsake
Copy link
Contributor Author

vatsake commented Mar 24, 2025

Added tests.
But is the format okay?

If json serializing Carbon for example:
json_encode(Carbon::now()) // ""2025-03-24T07:29:33.174073Z""
The date will be in ISO format.

@vatsake vatsake requested a review from belamov March 25, 2025 09:28
@belamov belamov merged commit a6b1d33 into belamov:master Mar 30, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@belamov belamov belamov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vatsake @belamov