add getters of bound in Range class #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belamov
requested changes
Dec 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 77 79 +2
===========================================
Files 21 21
Lines 189 184 -5
===========================================
- Hits 189 184 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
belamov
approved these changes
Dec 6, 2022
belamov
approved these changes
Dec 6, 2022
Contributor
Author
|
thank you for your review! |
Owner
|
thanks for contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes which extend
Belamov\PostgresRange\Ranges\Range::classhave only getters of$fromproperty and$toproperty but I need getters of$fromBoundproperties and$toBoundproperties.The reason why I need them is that when creating wrapper of Range classes such
TimestampRange::class, there are no way to recreate Range object from the wrapper.So I added them.