Bugfix/changelog #214
Bugfix/changelog #214
Conversation
|
@fliiiix I don't think so. Let me do a little digging (but this patch looks good to me, and thank you for doing this work!) |
3.1.13 seems to be tagged and the tag is pushed upstream. I'm not sure what you mean? I will merge this though. |
|
@tenderlove 🎉 thanks so the issue some people have is the github release feature. As you can see in the screenshot the previous relese is tagged as latest release. |
|
@fliiiix oh.... that is weird. I will try to figure out why that is. |
|
I think it's created manually on github and is not directly related with creating git tags. Thanks for taking care of it 👍👍👍 it's very appreciated |
|
I just created a release. I've never created one before, so hopefully I did it correctly. I just used the 3.1.13 tag. |
|
I think that's it. Thanks 🎉 |
- move a not released changelog entry out of 3.1.13 - remove a duplicated line - add a newline to the end of file Fixes bcrypt-ruby#214. Closes bcrypt-ruby#211. [ci skip]
sergey-alekseev
left a comment
There was a problem hiding this comment.
The 3 aforementioned issues are addressed in #219.
CHANGELOG
Outdated
| - Bump default cost to 12 [GH #181 by @bdewater] | ||
| - Remove explicit support for Rubies 1.8 and 1.9 | ||
| - Start calibration from the minimum cost supported by the algorithm [GH #206 by @sergey-alekseev] | ||
| - Remove explicit support for Rubies 1.8 and 1.9 [GH #185 by @tjschuck] |
There was a problem hiding this comment.
This line 96 duplicates the line 94.
CHANGELOG
Outdated
| - Remove explicit support for Rubies 1.8 and 1.9 [GH #185 by @tjschuck] | ||
| - Define SKIP_GNU token when building extension (Fixes FreeBSD >= 12) [GH #189 by @adam12] | ||
|
|
||
| [DRAFT] 4.0.0 MMM DD YYYY |
There was a problem hiding this comment.
Here is no newline at the end of file.
CHANGELOG
Outdated
| - Fix compatibility with libxcrypt [GH #164 by @besser82] | ||
|
|
||
| [DRAFT] 4.0.0 MMM DD YYYY | ||
| 3.1.13 May 31 2019 |
There was a problem hiding this comment.
My change - Start calibration from the minimum cost supported by the algorithm [GH #206 by @sergey-alekseev] couldn't be included into this release. The release was on May 31st 2019, I submitted #206 on July 6th 2019.
This also should address #211 so that 3.1.13 can be tagged as latest version.
@tjschuck or @tenderlove : there is no real reason that 3.1.13 is not tagged as latest?