Handle absolute paths in required_paths #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
kigster
approved these changes
Dec 13, 2023
Contributor
|
@JasonLunn is this PR identical to #142? If so I might prefer it due to using of |
Contributor
Author
|
They're definitely similar. I tried to minimize the touching the existing support for relative paths. My own habits would be to introduce the use of |
kigster
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gems with native extensions (like ffi) will sometimes have elements of
require_pathsthat are absolute rather than gem-path relative paths.It is incorrect to prepend those paths with the gem_path and Bazel will only allow relative paths as inputs to its glob() function, so they must be transformed to relative paths before being emitted.