cli.c: Allow 'channel request hangup' to accept patterns. #1695
Conversation
|
cherry-pick-to: none |
I'm not seeing how it would break current functionality, how come we can't cherry pick to existing versions? |
Just being conservative. I'll let others decide. |
|
Workflow PRCheck failed |
|
Workflow PRCheck completed successfully |
0a9140a to
4fa24bd
Compare
|
Workflow PRCheck completed successfully |
gtjoseph
left a comment
There was a problem hiding this comment.
Are you going to update ast_complete_channel() as well?
You mean |
So that if you enter a regex or glob and press Tab, it expands to all the matching channels. |
Does your shell do that? I have never seen that happen in dash or bash. |
No but the CLI does for non-regex or non-glob partial entries. |
4fa24bd to
6b5454b
Compare
6b5454b to
f2ffd26
Compare
f2ffd26 to
3c10753
Compare
No, I am not going to make that change. |
|
Workflow PRCheck completed successfully |
This extends 'channel request hangup' to accept multiple channel names, a POSIX Extended Regular Expression, a glob-like pattern, or a combination of all of them. UserNote: The 'channel request hangup' CLI command now accepts multiple channel names, POSIX Extended Regular Expressions, glob-like patterns, or a combination of all of them. See the CLI command 'core show help channel request hangup' for full details.
3c10753 to
547f558
Compare
There was a problem hiding this comment.
Attention! This pull request may contain issues that could prevent it from being accepted. Please review the checklist below and take the recommended action. If you believe any of these are not applicable, just add a comment and let us know.
- The PR description and/or commit message has malformed
UserNote,UpgradeNoteand/orDeveloperNotetrailers. TheUserNote,UpgradeNoteandDeveloperNotekeywords MUST be predeeded by a blank line and followed immediately by a colon and a space before the actual note text. This is to ensure that the note is properly formatted and displayed in the release change logs.
Documentation:
|
Workflow PRCheck completed successfully |
This extends 'channel request hangup' to accept multiple channel names, a POSIX Extended Regular Expression, a glob-like pattern, or a combination of all of them.
UserNote: The 'channel request hangup' CLI command now accepts multiple channel names, POSIX Extended Regular Expressions, glob-like patterns, or a combination of all of them. See the CLI command 'core show help channel request hangup' for full details.