Skip to content

Conversation

@ShobhitPatra
Copy link
Member

@ShobhitPatra ShobhitPatra commented Dec 15, 2025

This PR standardizes internal tap invariant error messages.
adds a consistent tap: prefix to all internal errors and shortens messages to match React-style invariants


Important

Standardizes error messages in tap package by adding tap: prefix and shortening messages across multiple files.

  • Error Message Standardization:
    • Adds tap: prefix to all error messages for consistency.
    • Shortens error messages to match React-style invariants.
  • Affected Files and Functions:
    • callResourceFn() in callResourceFn.ts: Changes "ResourceElement.type is not a valid Resource" to "tap: invalid resource element".
    • commitRender() in commit.ts: Updates multiple error messages, e.g., "Cannot find effect cell" to "tap: missing effect cell".
    • createResource() in createResource.ts: Changes "Resource not mounted" to "tap: resource not mounted".
    • withResourceFiber() in execution-context.ts: Updates "Rendered X hooks but expected Y" to "tap: hook order mismatch".
    • flushScheduled() in scheduler.ts: Changes "Maximum update depth exceeded" to "tap: maximum update depth exceeded".
    • getEffectCell() in tap-effect.ts and getStateCell() in tap-state.ts: Updates "Rendered more hooks than during the previous render" to "tap: hook order mismatch".

This description was created by Ellipsis for efcd1e1. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

⚠️ No Changeset found

Latest commit: efcd1e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

@promptless
Copy link
Contributor

promptless bot commented Dec 15, 2025

📝 Documentation updates detected!

New suggestion: Update tap error message format in troubleshooting documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant