Skip to content

Salsa 3, part 3 #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
g-r-a-n-t merged 5 commits into from
Feb 26, 2025
Merged

Salsa 3, part 3 #1061

g-r-a-n-t merged 5 commits into from
Feb 26, 2025

Conversation

@sbillig
Copy link
Collaborator

@sbillig sbillig commented Feb 20, 2025 •
edited
Loading

Bumping the salsa revision again to pick up the latest breaking changes

  • "coarse" tracked structs (struct fields aren't tracked as independent entities by default)
  • tracked fn return types must impl salsa::Update trait
  • derive(salsa::Supertype) allows us to avoid using salsa::interned wrapper structs around enums-of-salsa-ids (eg AdtRefId)

@sbillig sbillig marked this pull request as ready for review February 26, 2025 02:43
@sbillig sbillig requested a review from g-r-a-n-t February 26, 2025 02:44
@sbillig
Copy link
Collaborator Author

sbillig commented Feb 26, 2025

This has been updated to the latest salsa master, and is ready to merge.

Note that I had to replace IndexMap with OrderMap (because the latter implements the Hash trait), which is a light wrapper around IndexMap that changes some behavior to guarantee that the order remains consistent.

@g-r-a-n-t g-r-a-n-t merged commit 1c40071 into argotorg:master Feb 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g-r-a-n-t g-r-a-n-t g-r-a-n-t approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbillig @g-r-a-n-t