fix: add missing installation ownership check in VCS delete endpoint#11917
Open
yogeshwaran-c wants to merge 1 commit intoappwrite:1.9.xfrom
Open
fix: add missing installation ownership check in VCS delete endpoint#11917yogeshwaran-c wants to merge 1 commit intoappwrite:1.9.xfrom
yogeshwaran-c wants to merge 1 commit intoappwrite:1.9.xfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a tenant-isolation vulnerability in Confidence Score: 5/5Safe to merge — single-file security fix with no logic issues. The change is a one-liner ownership guard that exactly mirrors the existing check in Get.php. All necessary pieces (import, injection, parameter, guard) are present and correct. No P0/P1 findings. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix: add missing installation ownership ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /v1/vcs/installations/:installationIdGET /v1/vcs/installations/:installationIdendpoint already performs this check ($installation->getAttribute('projectInternalId') !== $project->getSequence()), and thelistInstallationsendpoint scopes its query byprojectInternalId— so this was an oversight in the delete endpointTest plan
204 No Contentas beforeINSTALLATION_NOT_FOUND) instead of succeedinggetInstallationandlistInstallationsbehavior is unchanged