feat: use HikariCP instead of commons-dbcp2 for connection pooling #6576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
commons-dbcp2seems to be to heavyweight, and the newer versions pulljakarta.transactionfor unknown reasons.Let's stick with a well-known faster and smaller pool.
There's an issue with the current JMeter implementation: it seems to rely on transactions (==uncommitted data within connections), however, it does not manage the transactions properly.
JMeter should have dedicated
JdbcTransactionorJtaTransactionelements (e.g. like@TransactionalSpring), so JDBC samplers within thatJdbcTransactioncontroller would reuse the same transaction.Currently, JMeter borrows and releases a connection to the pool for every JDBC sampler execution, thus it can't reliably work with transactions. There's no guarantee that subsequent "borrow" would borrow the same connection. The connection pooler should rollback a dirty connection on release anyways.
So the change looks bigger than I initially planned.
TODO:
JdbcTransactioncontroller element so it would keep a connection