fix(tui): improve macOS terminal restoration on exit #7860
+196
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
RandyMcMillan
commented
Jan 11, 2026
| @@ -1,5 +1,15 @@ | |||
| import { RGBA } from "@opentui/core" | |||
|
|
|||
| export function isMacOSTerminal(): boolean { | |||
Author
There was a problem hiding this comment.
isMacOSTerminal: additional OS tests may be added in a follow up PR to be more cross platform compatible.
Testing for Windows is outside of the scope of this PR.
Author
fixes: #7861 |
Add comprehensive macOS terminal handling to prevent 'dead terminal' issues: - Enhanced signal handling for SIGINT, SIGHUP, SIGTERM - Improved suspend/resume with proper alternate screen buffer management - Comprehensive exit cleanup with terminal reset sequences - Added macOS terminal detection utility Ensures terminal is properly restored to usable state when opencode shuts down, preventing scrambled terminals and requiring manual resets. 00-00000244
Add comprehensive test utility for macOS terminal functionality: - Tests macOS terminal detection logic - Validates terminal reset escape sequences - Verifies signal handler setup and cleanup - Mocks renderer for isolated testing Ensures terminal restoration changes work correctly across different macOS environments. 00-00000232
Add macOS terminal restoration testing to CI workflows: - Test script runs on macOS runners in nix-desktop workflow - Test script runs on macOS Tauri builds in publish workflow - Validates terminal restoration before desktop builds - Ensures future changes don't break macOS terminal functionality 00-00000fd9
000b3b0 to
000466a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7861
Summary:
Fixes the "dead terminal" issue that occurs when opencode exits on macOS, leaving users with a corrupted terminal state that requires manual reset.
Changes:
Technical Details:
Testing: