-
Notifications
You must be signed in to change notification settings - Fork 430
Feature: Multi-language support #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Multi-language support #249
Conversation
The framework now supports both English and Swedish out of the box. Users can add own translations via the dashboardProvider.
|
Looks really nice. Great job. I would love to see it in the next version. But i'm not sure if i like the name "culture", i think i would feel more comfortable with a name like i18n, locale, l10n or something like this. Is there a special reason for culture? Do we need a new module or could we add it to adf.provider, to reduce complexity? |
|
This would fix #102 |
|
The documentation should be placed elsewhere in the wiki, extra file or we could add some extra pages to the api documentation. But i think the readme would get too long. |
|
I had a hard time deciding the name to be honest :) I have used kendo alot and they are using culture, but a culture also has an affect on dateformats and stuff, so it may be the wrong module name to use. adf.locale is good module name. dashboardProvider.setLocale('en-US')I think it should be a own module, since it has a very narrow scope. That helps with the unit testing if we where to extend the locacle module with its own provider and translation factory that we later could inject into the dashboardProvider. Sound good? PS. I will update the naming from culture to locale tomorrow :) |
|
Yes, sounds good for me. |
Updated all related variable and function names to use locale instead of culture.
Should create a wiki page for this instead.
…k/master' into feature/language-support
|
Thank you very much. |
|
@sdorra thank u :) would love som help regarding the wiki. Maybe we can take that privately over gitter? |
Feature
Why?
It can seem to be little bit tacky when a system doesnt uses English, in my case our system is in Swedish and all adf labels/tooltips are in English. I think the language support takes the framework to the next level.
Hope you like it :)