Skip to content

BUG-fix: enableConfirmDelete is now configurable via attribute #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sdorra merged 1 commit into from
May 26, 2016
Merged

BUG-fix: enableConfirmDelete is now configurable via attribute #248

sdorra merged 1 commit into from
May 26, 2016

Conversation

@chaaya
Copy link
Contributor

@chaaya chaaya commented May 26, 2016

The bug is that the value of enableConfirmDelete always becomes false
beacuse it binds to a attribute that is lowercased. In the documenation it
clearly states that the attribute should be written like
enable-confirm-delete. Wich means that is has to be camelcased in the
directive.

<adf-dashboard
       name="{string}"
       [editable="{boolean}"]
       [collapsible="{boolean}"]
       [maximizable="{boolean}"]
       [enable-confirm-delete="{boolean}"]
       [structure="{string}"]
       [adf-model="{object}"]
       [adf-widget-filter="{function}"]
       [continuous-edit-mode="{boolean}"]>
</adf-dashboard>

@chaaya
Option enableConfirmDelete is now configurable via attribute to adf-d…
1d14eb1 
…ashboard

The bug is that the value of enableConfirmDelete always becomes false
beacuse it binds to attribute that is lowercased. In the documenation it
clearly states that the attribute should be written like
enable-confirm-delete with means that is has to be camelcased in the
directive.
@chaaya chaaya changed the title enableConfirmDelete is now configurable via attribute BUG-fix: enableConfirmDelete is now configurable via attribute May 26, 2016
@coveralls
Copy link

coveralls commented May 26, 2016

Coverage Status

Coverage remained the same at 92.52% when pulling 1d14eb1 on momentumsoftwareab:bug-fix/enable-confirm-on-delete into 3b910f9 on angular-dashboard-framework:master.

@sdorra sdorra merged commit 874c6ac into angular-dashboard-framework:master May 26, 2016
@sdorra
Copy link
Member

sdorra commented May 26, 2016

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chaaya @coveralls @sdorra