-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix build on GitHub Actions for lifecycle, navigation and paging
#777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: androidx-main
Are you sure you want to change the base?
Conversation
:window:extensions:extensions:window:window to use the tip of :window:extensions:extensions
:window:window to use the tip of :window:extensions:extensionslifecycler, navigation and paging
lifecycler, navigation and paginglifecycle, navigation and paging
|
|
a1092bb to
9eac9ca
Compare
|
Some builds fail again because Lifecycle 2.9.1 is not available yet (the update comes from 2bd44d6). |
45360f6 to
51ee0cc
Compare
|
Lifecycle 2.9.1 was released, so I've updated this PR, and the build is green(-ish) again |
dfd6f93 to
ebfebc1
Compare
d328644 to
045cd2d
Compare
045cd2d to
5a42f90
Compare
|
The remaining failures are coming from Compose because of:
|
5a42f90 to
a52a7fd
Compare
| androidTestImplementation(extensions_core_version) | ||
| androidTestImplementation(compileOnly(project(":window:sidecar:sidecar"))) | ||
| androidTestImplementation(compileOnly(extensions_version)) | ||
| androidTestImplementation(project(":window:sidecar:sidecar")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spotting. Will land this as r.android.com/3679958
e193b57 to
e23b3cf
Compare
9bdd7c3 to
2806fdb
Compare
2806fdb to
704de85
Compare
…avigation:integration-tests:testapp`
704de85 to
1a1b39f
Compare
Proposed Changes
Replace the fixed version dependency on
androidx.window.extensions:extensionsto use a project dependency in:window:windowto fix unresolved references when building:lifecycle,:navigationand:paging.Replace some project dependencies on
:activity:activitywith a pinned version to 1.10.1 to fix the resultingType androidx.activity.ActivityViewModelLazyKt$viewModels$1 is defined multiple timeserror.Add a step to free some spaces in the runner so every step can build.
Testing
Test: GitHub Actions pass for every supported module.
Issues Fixed
Fixes: N/A