Produce unsigned release builds on CI #89
Conversation
This change modifies the build process to produce unsigned AABs for release builds when executed in a CI environment. The `CI_BUILD=true` project property is introduced and passed during CI builds (`build.sh` and `build_presubmit.sh`). In `app/build.gradle.kts`, the release build type now conditionally applies the `signingConfig`. If `CI_BUILD` is true, no `signingConfig` is applied, resulting in an unsigned AAB. Otherwise (for local builds), the debug signing key is used as before. This allows CI to build release artifacts without requiring access to production signing keys, while developers can still build and run the release variant locally using the debug key.
There was a problem hiding this comment.
Summary of Changes
Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines our Android build process to better accommodate Continuous Integration (CI) environments. The core change allows CI systems to produce unsigned release Android App Bundles (AABs), thereby removing the need for production signing keys to be present or exposed within the CI pipeline. Local developer builds of the release variant remain unaffected, continuing to use the debug signing key for convenience.
Highlights
- Conditional Signing Logic: I've updated
app/build.gradle.ktsto conditionally apply thesigningConfigfor release builds. If theCI_BUILDproject property is detected astrue, the build will produce an unsigned AAB. Otherwise (for local development), it will continue to use the debug signing key, allowing developers to easily run the release variant locally. - CI Build Property Introduction: I've introduced a new
CI_BUILD=trueproject property. This property is now passed to Gradle when executing theapp:bundleReleasetask in bothbuild.shandbuild_presubmit.shscripts, signaling to the Gradle build that it's running in a CI environment.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request modifies the build process to produce unsigned AABs for release builds in a CI environment. A suggestion has been provided for app/build.gradle.kts to improve code clarity by simplifying a boolean check and using the standard Gradle logger.
This change modifies the build process to produce unsigned AABs for release builds when executed in a CI environment.
The
CI_BUILD=trueproject property is introduced and passed during CI builds (build.shandbuild_presubmit.sh).In
app/build.gradle.kts, the release build type now conditionally applies thesigningConfig. IfCI_BUILDis true, nosigningConfigis applied, resulting in an unsigned AAB. Otherwise (for local builds), the debug signing key is used as before.This allows CI to build release artifacts without requiring access to production signing keys, while developers can still build and run the release variant locally using the debug key.