Kokoro internal configuration: Add installation of java / android sdk and temporarily disable baseline profiles #85
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on making the Android application's build process more robust and self-contained. It introduces comprehensive automation for setting up the required Java and Android SDK environments within the build.sh script, ensuring that the build can be executed consistently across different machines. Concurrently, it temporarily disables the automatic generation of baseline profiles, streamlining the current build configuration.
Highlights
- Automated Android Build Environment Setup: The
build.shscript has been significantly enhanced to automate the complete setup of the Android development environment. This includes checking for essential prerequisites (wget,unzip,tar), installing Java Development Kit 17 system-wide, downloading and configuring the Android SDK command-line tools, and installing necessary SDK packages such as platforms, build tools, an emulator, and a system image. This ensures a consistent and reproducible build environment for the project. - Temporary Disablement of Baseline Profile Generation: Automatic generation of baseline profiles has been explicitly disabled. This is reflected in
app/build.gradle.ktswherebaselineProfile.automaticGenerationDuringBuildis set tofalse. Additionally, thebuild.shscript now passes-Pandroid.baselineProfile.automaticGenerationDuringBuild=falseto thebundleReleaseGradle task, ensuring that baseline profiles are not generated during the build process.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive build script to automate the setup of the Java and Android SDK environment for CI builds. It also disables automatic baseline profile generation.
My review focuses on improving the portability, robustness, and maintainability of the new build.sh script. Key suggestions include:
- Replacing the system-wide Java installation with a local, self-contained setup to remove the
sudodependency and improve portability. - Highlighting the brittle nature of the hardcoded Android SDK download URL.
- Simplifying the build success check by removing redundant logic made unnecessary by
set -e.
build.sh
Outdated
| CMDLINE_TOOLS_URL="https://dl.google.com/android/repository/commandlinetools-linux-13114758_latest.zip" | ||
|
|
There was a problem hiding this comment.
The hardcoded URL for the Android command-line tools points to a specific build number (13114758). This URL is likely to become outdated or be removed in the future, which would break this script.
For better maintainability, I recommend moving this CMDLINE_TOOLS_URL variable to the configuration section at the top of the script. This makes it easier to find and update when a new version is required.
…into feature/kokoro
Create two configs for Kokoro, one presubmit and one continuous.