Updates the open on phone behavior in the Wear OS app #149
Conversation
Summary of ChangesHello @garanj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience when interacting with the 'Open on phone' feature in the Androidify Wear OS app. Instead of blindly attempting to launch the phone app, the system now intelligently verifies the phone app's presence and capability via the Data Layer. This ensures that users are either seamlessly directed to the running Androidify app or gracefully guided to its Play Store page for installation or update, preventing broken links and enhancing reliability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively updates the 'Open on phone' behavior by introducing a capability check, which makes the interaction more robust. The switch from runBlocking to lifecycleScope.launch is an excellent improvement for performance and responsiveness. The code is well-structured, and the new constants improve clarity. My review includes a few suggestions focused on improving code style and maintainability by refactoring some logic and extracting hardcoded strings into constants.
Updates the Open on phone behavior in the app and default watch face on the watch.
Previously this would just try to launch Androidify, making the assumption it was installed.
Changes
Potential temporary edge case
If the user launches Androidify from the watch, using this latest change, but the Androidify on the phone has not yet been updated (but is installed), then this will launch the Play store details page, not the Androidify app: This is because older versions of the Androidify app do not have the static capability defined.
However, this case will soon disappear as the app updates, and even if it does happen, the Play store offers an immediate "open" button so those affected users will not be significantly impacted.
It is also deemed to be unlikely that users will have the watch app and not the phone app anyway.
An alternative would be to roll out the static capability first, wait for adoption and then roll out the changes to the Wear OS app.