Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Use OrderedDict to preserve elements order when parsing templates #4

Merged
paoptu023 merged 1 commit into from
Nov 16, 2018
Merged

Use OrderedDict to preserve elements order when parsing templates #4

paoptu023 merged 1 commit into from
Nov 16, 2018

Conversation

@paoptu023
Copy link
Contributor

@paoptu023 paoptu023 commented Nov 16, 2018

Description of changes:

  • Modify yaml parser to use OrderedDict, add corresponding tests.
  • Fix small bugs introduced during branches clean up

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@paoptu023 paoptu023 requested review from honglu and jlhood November 16, 2018 01:28
jlhood
jlhood approved these changes Nov 16, 2018
View reviewed changes
Copy link

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for fixing this!

@paoptu023 paoptu023 merged commit 126852e into master Nov 16, 2018
@paoptu023 paoptu023 deleted the ordered-parsing branch November 16, 2018 01:50
@sriram-mv sriram-mv mentioned this pull request Feb 10, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@honglu honglu honglu approved these changes

@jlhood jlhood jlhood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paoptu023 @honglu @jlhood