Fix: Not collapsable gradients with canvas renderer#3152
Open
Quatern1on wants to merge 1 commit intoairbnb:masterfrom
Open
Fix: Not collapsable gradients with canvas renderer#3152Quatern1on wants to merge 1 commit intoairbnb:masterfrom
Quatern1on wants to merge 1 commit intoairbnb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When gradient color stops offsets do not align with alpha stops offsets, Canvas renderer just renders without using alpha at all. This PR uses algorithm that merges colors and alpha stops into single array of colors with alpha that correctly represents such gradient and can be used with CanvasGradient.
Example animation that is rendered differently with canvas renderer: break.json