AG-11882-master-detail-csrm-guard #12191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- renamed createRowCon to createRowCtrl for clarity - updated row control creation to respect master-detail state - added logic to refresh rows based on isRowMaster callback - introduced shouldSetMasterDetailFlag method for better readability
…-to-update-whether-they-display-an-expansion-button/AG-11882
- Remove redundant shouldSetMasterDetailFlag method. - Simplify master-detail flag checks in updateDataIntoRowNode. - Enhance refreshRow to ensure correct rendering based on row master status. - Update setDataCommon to allow dynamic master flag during runtime.
…-to-update-whether-they-display-an-expansion-button/AG-11882
- Replace updateData with updateDataInternal in multiple files for consistency - Simplify master determination logic in setMaster method - Remove unnecessary comments and improve clarity in rowCtrl and rowNode - Ensure internal updates do not trigger master checks unnecessarily
- Changed from internal to external data update to trigger refreshes
- Replace updateDataInternal with updateData in multiple files for uniformity. - Update master-detail service to listen for rowNodeDataChanged events. - Simplify setDataCommon method by removing internal flag handling.
Contributor
|
thanks Salvo, let's keep it open until we come up with a good solution which may be yours |
Base automatically changed from
sdwvit/fix/master-detail/allow-master-rows-to-update-whether-they-display-an-expansion-button/AG-11882
to
latest
October 13, 2025 14:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a updatingRowData flag that prevent to call setMaster before the whole rowData is loaded by CSRM
master detail service already uses setMasters, called by CSRM, to set the row master after all the row data is loaded
We don't want to change when isMaster is called for the user while the data is loaded, and we don't want to have isMaster called twice