Fixed SEGFAULT when calling remove_event_detect() and added epoll_ctl() return code handling #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added more elaborate epoll() error logging
* Added comments * Added debug logging * Line 724 - now <initial> flag is properly reset upon removal of event detection from GPIO pin
Collaborator
|
@zsserg thanks for creating this pull request! I will test out and merge if no issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is a follow-up for the PR #233 - as the library uses 2-tier system for callbacks and #233 patched only one place, it still kept crashing on rare occasions. I implemented the same approach to work around it.
Besides that, I made more elaborated the syslogged error messages from epoll_ctl() to make it easier to understand what the problem might be. epoll_ctl() has around 15 different return error codes, before this PR the library just reported general error without any details. Now it actually logs the epoll_ctl() error code, if any.