Allow to remove device information from junit report #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tylervick One detail: I noticed the version |
acecilia
commented
Sep 2, 2022
b608af4 to
0e4c74f
Compare
Contributor
Author
|
@tylervick 👋 🙂 Any chance of getting your opinion on this? 🙏 |
Member
|
Great job! |
Contributor
Author
tylervick
approved these changes
Sep 8, 2022
Member
tylervick
left a comment
There was a problem hiding this comment.
Awesome, thank you! Thank you for the detailed analysis w.r.t. junit modification.
Member
🤦 we need a version bump job or something for this. It's unfortunate that SPM doesn't really have a good versioning paradigm.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR is an implementation of the discussions in #115