Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | Sponge
ParticleOptions:
DIRECTIONandPOTION_EFFECT_TYPEoptions due to them being legacyOPACITYoption to supportParticleTypes.ENTITY_EFFECT(it uses ARGB int as color, so it's represented asCOLORandOPACITYoptions)DESTINATIONoption to supportParticleTypes.VIBRATIONITEM_STACK_SNAPSHOToption to be explicitly not empty because minecraft throws exception on empty itemstack anywayPositionSource:
Entitywith some vertical offset or reference toBlockPos(it's packed into vibration particle and sent to client)Locatablebut I can't come up with good name (maybe something likeResolvablePosition, idk)Optional<Vector3d> position(World)(mirrored from originalPositionSource) but I'm not sure if it should be exposed