Skip to content

Remove the restriction that listener methods must be public #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zml2008 merged 1 commit into from
Jul 19, 2021
Merged

Remove the restriction that listener methods must be public #2376

zml2008 merged 1 commit into from
Jul 19, 2021

Conversation

@zml2008
Copy link
Member

@zml2008 zml2008 commented Jul 11, 2021 •
edited
Loading

SpongeAPI | Sponge

The allowed event listeners here are not a strict superset of those allowed in api 8 -- most notably, event methods cannot be picked up from supertypes anymore. This restriction could be relaxed by traversing supertypes, but it would make the class generation logic more complicated, and is imo a fringe use case.

@zml2008 zml2008 self-assigned this Jul 11, 2021
@zml2008 zml2008 mentioned this pull request Jul 11, 2021
Merged
@zml2008 zml2008 force-pushed the api9/non-public-listeners branch from 2025211 to 51f6e5f Compare July 18, 2021 21:21
@zml2008 zml2008 changed the title Relax the restriction that event listener methods must be public Remove the restriction that listener methods must be public Jul 19, 2021
@zml2008 zml2008 merged commit dc1bfca into api-9 Jul 19, 2021
@zml2008 zml2008 deleted the api9/non-public-listeners branch July 19, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zml2008 zml2008

Labels

api: 9 (u) version: 1.18 system: event type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zml2008