Move default Redis connection string out of CD spec into secret #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parate K8s secret to allow for easier population of custom connection string
ghost
reviewed
Dec 17, 2020
ghost
left a comment
There was a problem hiding this comment.
Thanks for your input @robhabraken.
We will however reject this PR, as we do not accept PR's to this repo master branch (please see the README). The reason being that source is actually hosted internally, this repo is only used to publish released versions.
We might consider creating a separate "contrib" branch in the future for input and suggestions. However this has not been decided yet.
I have asked the team to look at and evaluate your proposal.
Author
|
Thanks Jonas! I only saw this remark in the README after submitting my PR. Thanks for evaluating my proposal and looking forward to a contrib branch! |
Member
|
@michaelbaranov can you share with the container team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes specification files as provided contain a hard-coded connection string to Redis. You can of course change it in there (the cd.yaml spec file in your repo), but I think it is more elegant to remove the value from the specification files and place it inside a secrets file, as is being done with the Solr connection string. This makes the spec file implementation-agnostic, easier to upgrade and not containing environment specific variables / parameters. Subsequently, you can choose to retrieve this connection string value either from an Azure DevOps Variable group, or by using a secret from your Azure KeyVault instance for example, to inject the correct value in the secrets file at provisioning-time.
I also mentioned this in my blog post https://www.robhabraken.nl/index.php/3619/paas-to-aks-arm-for-eds/, this is the corresponding Pull Request of said change to the spec files.