Skip to content

Squeak fixes camp 2025 2 #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbrichau merged 5 commits into from
Jul 13, 2025
Merged

Squeak fixes camp 2025 2 #188

jbrichau merged 5 commits into from
Jul 13, 2025

Conversation

@marschall
Copy link
Contributor

@marschall marschall commented Jul 10, 2025

  • no longer support Squeak 5.3
  • rename Pharo classes in Squeak packages to Squeak
  • add empty PackageManifest class for Squeak

Fixes #186, #187

marschall added 2 commits July 10, 2025 16:10
@marschall
Camp 2025 Squeak fixes round 2
9b3e2fe 
- no longer support Squeak 5.3
- rename Pharo classes to Squeak
- add PackageManifest class
@marschall
Delete old Squeak code
3841b25
@marschall marschall force-pushed the squeak-fixes-camp-2025-2 branch from f5c765e to 3841b25 Compare July 10, 2025 14:10
@marschall marschall self-assigned this Jul 10, 2025
@marschall marschall requested a review from jbrichau July 10, 2025 14:11
@codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.75%. Comparing base (6e62ecb) to head (93871a5).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...GRSqueakGenericCodec.class/instance/encoderFor..st 0.00% 1 Missing ⚠️
.../GRSqueakLatin1Codec.class/instance/decoderFor..st 0.00% 1 Missing ⚠️
...ge/GRSqueakUtf8Codec.class/instance/decoderFor..st 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   86.83%   86.75%   -0.09%     
==========================================
  Files        1862     1855       -7     
  Lines       12848    12766      -82     
==========================================
- Hits        11157    11075      -82     
  Misses       1691     1691

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marschall
Copy link
Contributor Author

marschall commented Jul 10, 2025

I have no idea why the CI is failing:

UndefinedObject(Object)>>error:
UndefinedObject(Object)>>errorNonIntegerIndex
UndefinedObject(Object)>>at:
MCFileTreeStCypressReader>>addClassDefinitionFrom:comment:
MCFileTreeStCypressReader>>addClassAndMethodDefinitionsFromEntry:
[] in MCFileTreeStCypressReader>>addClassAndMethodDefinitionsFromDirectory:
Array(SequenceableCollection)>>do:
MCFileTreeStCypressReader>>addClassAndMethodDefinitionsFromDirectory:

If I had do guess I would say that classPropertiesDict is nil. Either

classPropertiesDict := STON fromStream: fileStream

is nil or never called. Maybe I missed committing a file.

@marschall marschall marked this pull request as draft July 10, 2025 14:54
@marschall marschall removed the request for review from jbrichau July 10, 2025 14:54
@marschall marschall marked this pull request as ready for review July 10, 2025 15:38
@marschall marschall requested a review from jbrichau July 10, 2025 15:38
jbrichau
jbrichau approved these changes Jul 13, 2025
View reviewed changes
Copy link
Member

@jbrichau jbrichau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted some filetree artefacts but other than that, I assume the Squeak changes to be OK. Thanks for taking care of this. The Squeakers will thank you.

@jbrichau jbrichau merged commit 77f66fb into SeasideSt:master Jul 13, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrichau jbrichau jbrichau approved these changes

Assignees

@marschall marschall

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Squeak 5.x support

2 participants

@marschall @jbrichau