Skip to content

Camp 2025 Squeak fixes round 1 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marschall merged 1 commit into from
Jul 9, 2025
Merged

Camp 2025 Squeak fixes round 1 #185

marschall merged 1 commit into from
Jul 9, 2025

Conversation

@marschall
Copy link
Contributor

@marschall marschall commented Jun 29, 2025

  • remove classCommentOf:, part of swagger
  • remove GRWorkingWriteStream, no need
  • add pad* methods

@marschall
Camp 2025 Squeak fixes round 1
613596b 
- remove classCommentOf:, part of swagger
- remove GRWorkingWriteStream, no need
- add pad* methods
@marschall marschall requested a review from jbrichau June 29, 2025 14:21
@marschall marschall self-assigned this Jun 29, 2025
@codecov
Copy link

codecov bot commented Jun 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.83%. Comparing base (d259247) to head (613596b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ckage/String.extension/instance/padLeftTo.with..st 0.00% 3 Missing ⚠️
...kage/String.extension/instance/padRightTo.with..st 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   86.83%   86.83%   -0.01%     
==========================================
  Files        1863     1862       -1     
  Lines       12856    12848       -8     
==========================================
- Hits        11164    11157       -7     
+ Misses       1692     1691       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marschall marschall merged commit 6e62ecb into SeasideSt:master Jul 9, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrichau jbrichau jbrichau approved these changes

Assignees

@marschall marschall

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marschall @jbrichau