Skip to content

Fix Pharo 12 deprecations #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
theseion wants to merge 6 commits into from
Closed

Fix Pharo 12 deprecations #162

theseion wants to merge 6 commits into from

Conversation

@theseion
Copy link
Member

@theseion theseion commented Oct 31, 2023 •
edited
Loading

  • add specific packages for Pharo 12 (copied older versions)
  • fix deprecations specific to Pharo 12
  • add new methods to platforms (for tests only)

Not sure about the new selectors. I would have put them in a test only package but there was none. We could create these methods as extensions by creating platform specific test packages.

This PR will fix test failures in Pharo 12 in #161.

@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Attention: 241 lines in your changes are missing coverage. Please review.

Comparison is base (05a6c4e) 84.57% compared to head (5145add) 84.10%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   84.57%   84.10%   -0.48%     
==========================================
  Files        2017     2263     +246     
  Lines       13558    14840    +1282     
==========================================
+ Hits        11467    12481    +1014     
- Misses       2091     2359     +268
Files Coverage Δ
....package/GRPlatform.class/instance/classSideOf..st 100.00% <100.00%> (ø)
...defineClass.superclassName.category.forRBModel..st 100.00% <100.00%> (ø)
...ckage/GRPlatform.class/instance/removeCategory..st 100.00% <100.00%> (ø)
...orm.class/instance/selectorsInProtocol.ofClass..st 100.00% <100.00%> (ø)
...re.package/Behavior.extension/instance/fullName.st 100.00% <100.00%> (ø)
....extension/instance/valueWithPossibleArguments..st 100.00% <100.00%> (ø)
...ckage/ByteArray.extension/instance/greaseString.st 100.00% <100.00%> (ø)
...kage/Character.extension/instance/greaseInteger.st 100.00% <100.00%> (ø)
...-Core.package/Collection.extension/instance/any.st 100.00% <100.00%> (ø)
...re.package/Color.extension/instance/asHTMLColor.st 100.00% <100.00%> (ø)
... and 194 more

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau
Copy link
Member

jbrichau commented Oct 31, 2023

@theseion The Pharo12 build is an accepted failure. Since it's a moving target, it's ran as an experimental job only. You should be able to merge the PR without further issues.

But cool to already have some pharo12 issues addressed! Thanks! I'll review then later. Currently off for the week ;-)

@theseion
Copy link
Member Author

theseion commented Nov 1, 2023

Done. As I wrote above, I'm not sure about the new methods on GRPlatform.

@theseion theseion requested a review from jbrichau November 1, 2023 07:15
@jbrichau
Copy link
Member

jbrichau commented Dec 27, 2023

In the meantime, I had been doing some pair programming with Noury at a Pharo sprint to rework the Slime rule tests in Pharo 12 in #164

I will need selectively redo some of the changes in this PR

@jbrichau
Copy link
Member

jbrichau commented Feb 4, 2024 •
edited
Loading

Changes in this PR have been addressed in the following other PRs that focused on the Slime rules code:

I have now also addressed the sends of deprecated messages that remained in #172

The additions that were made to Grease-Core related to creating test classes for the Slime tests. Since this is now Pharo-only code anyway, I do not think we should add them to the Core (and create implementations for all supported platforms for them).
Therefore, I propose to close this PR.

@jbrichau jbrichau closed this Feb 4, 2024
@theseion theseion deleted the fix-pharo12-deprecations branch February 4, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrichau jbrichau Awaiting requested review from jbrichau

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theseion @jbrichau