mediarecorder: Add recording format selector
#8647
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediarecorder: Add recording format selector
Member
|
The inline dropdown is an interesting idea, but I think putting it on a separate line would be better. Since the popup is already quite tall, some of the existing elements could be made smaller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8074
Resolves #8087
Changes
Adds a selector to the
mediarecordervideo recording options dialog that allows you to choose between recording as mp4 and webm, if available.Reason for changes
To allow users to choose the recording format that works best for them.
Tests
Tested on Edge.