Do not reload when changing forceEnglish #8595
Conversation
|
Probably no edge cases at the moment, but it could become a problem in the future. Maybe you can achieve this exact same user experience (i.e. the tab not closing) while also reloading the extension. For example, by redirecting the user to a |
| scratchAddons.localState.ready.manifests = false; | ||
| scratchAddons.manifests = []; | ||
| await loadAddonManifests(); | ||
| sendResponse("done"); |
There was a problem hiding this comment.
It looks like this respose is never received.
Unchecked runtime.lastError: The message port closed before a response was received.
There was a problem hiding this comment.
It is not necessary to send a response.
If you really want to send one, then you need to return true; and avoid the use of async/await in favor of normal promises. (this is how asynchronously sending a response works with the chrome messaging API)
Changes
Changing the "Show addon names and descriptions in English" setting now only requires a settings page reload instead of a full extension reload.
Force.English.setting.toggle.reloads.page.mp4
Reason for changes
It's better to reload only the resources that are necessary.
Tests
Tested in Edge 141. Addons still work after toggling setting.
Help me find edge cases?