Skip to content

[NUI][API13_MR](Window) Add API to request rendering forcibly.#7559

Open
hinohie wants to merge 1 commit intoSamsung:API13_MRfrom
hinohie:window_force_render_api13_mr
Open

[NUI][API13_MR](Window) Add API to request rendering forcibly.#7559
hinohie wants to merge 1 commit intoSamsung:API13_MRfrom
hinohie:window_force_render_api13_mr

Conversation

@hinohie
Copy link
Copy Markdown
Contributor

@hinohie hinohie commented Apr 10, 2026

Support API to make the window render forcibly.

KeepRendering might skip render actions if their is nothing upated. And RenderOnce() API request rendering immediatly, before message flushing.

So we need to make some seperated API, sync with message flush timing.

Usually be used pairwise with AddFrameRenderedCallback or AddFramePresentedCallback.

Description of Change

API Changes

  • ACR:

[NUI][API13_MR](Window) Add API to request rendering forcibly.
0fdf90d 
Support API to make the window render forcibly.

KeepRendering might skip render actions if their is nothing upated.
And RenderOnce() API request rendering immediatly, before message flushing.

So we need to make some seperated API, sync with message flush timing.

Usually be used pairwise with `AddFrameRenderedCallback` or `AddFramePresentedCallback`.

Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
@github-actions github-actions bot added the API13_MR Platform : Tizen 10.0 / TFM: net8.0-tizen10.0 label Apr 10, 2026
@TizenAPI-Bot
Copy link
Copy Markdown
Collaborator

TizenAPI-Bot commented Apr 10, 2026

Internal API Changed

Added: 1, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Window::SetForceRendering(System.UInt32)

@JoonghyunCho
Copy link
Copy Markdown
Member

JoonghyunCho commented Apr 15, 2026

Code Review

1. Grammar issue in XML summary
The summary reads: 'Request to rendering forcibly for this window' -- should be 'Requests forced rendering for this window.' (imperative verb, ends with a period).

2. Malformed XML doc comment
The line 'This will be public opened in tizen_next after ACR done. Before ACR, need to be hidden as inhouse API.' appears inside the triple-slash doc block without any XML tag. This renders as raw untagged text in documentation output. Wrap it in a remarks tag or move it outside the doc comment as a regular comment.

3. Minor: existing typo in interop
In Interop.WindowInternal.cs, the parameter name 'nuiCallbakc' on AddFramePresentedCallback is a typo (should be nuiCallback). Not introduced by this PR, but worth fixing while touching the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@bshsqa bshsqa Awaiting requested review from bshsqa bshsqa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

API13_MR Platform : Tizen 10.0 / TFM: net8.0-tizen10.0 Internal API Changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hinohie @TizenAPI-Bot @JoonghyunCho