Skip to content

SealedSecret filter#830

Merged
babenek merged 12 commits intoSamsung:mainfrom
babenek:secseal
Apr 15, 2026
Merged

SealedSecret filter#830
babenek merged 12 commits intoSamsung:mainfrom
babenek:secseal

Conversation

@babenek
Copy link
Copy Markdown
Contributor

@babenek babenek commented Apr 11, 2026 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add ValueSealedSecretCheck filter
  • Fix MyPy issues and stubs
  • R1705 fix

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek closed this Apr 11, 2026
@babenek babenek reopened this Apr 11, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 11, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.97590% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.30%. Comparing base (f08ff24) to head (b1c2009).

Files with missing lines Patch % Lines
credsweeper/file_handler/diff_content_provider.py 71.42% 1 Missing and 1 partial ⚠️
credsweeper/deep_scanner/docx_scanner.py 66.66% 0 Missing and 1 partial ⚠️
credsweeper/filters/value_token_base64_check.py 0.00% 1 Missing ⚠️
credsweeper/scanner/scanner.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   92.27%   92.30%   +0.03%     
==========================================
  Files         145      146       +1     
  Lines        5904     5929      +25     
  Branches      966      972       +6     
==========================================
+ Hits         5448     5473      +25     
  Misses        294      294              
  Partials      162      162

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babenek babenek marked this pull request as ready for review April 12, 2026 13:52
@babenek babenek requested a review from a team as a code owner April 12, 2026 13:52
Pomidorry
Pomidorry approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Pomidorry Pomidorry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xDizzix
xDizzix approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babenek babenek merged commit 24d5590 into Samsung:main Apr 15, 2026
32 checks passed
@babenek babenek deleted the secseal branch April 15, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xDizzix xDizzix xDizzix approved these changes

@Pomidorry Pomidorry Pomidorry approved these changes

@Yullia Yullia Awaiting requested review from Yullia

@iuriimet iuriimet Awaiting requested review from iuriimet

@csh519 csh519 Awaiting requested review from csh519

@404DevVP 404DevVP Awaiting requested review from 404DevVP

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@babenek @codecov-commenter @xDizzix @Pomidorry