Fix timezone bug in Python test spec by using Unix timestamps #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace %ci (formatted date with timezone) with %ct (Unix timestamp) - Use numeric comparison instead of string comparison for timestamps - Simplify date arithmetic using Unix epoch time instead of date -d - Change --since to --after parameter for git log with timestamp This fixes potential timezone-related issues when comparing commit times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a timezone-related bug in the Python test specification that could cause issues when comparing commit timestamps across different timezones.
Changes
%ci(formatted date with timezone) with%ct(Unix timestamp) in git show commandsdate -d--sinceto--afterparameter for git log with timestampImpact
This eliminates potential timezone-related issues when comparing commit times during repository setup, ensuring consistent behavior regardless of the system's timezone configuration.
Testing
The changes maintain the same logical behavior while using more robust timestamp handling.