Skip to content

Add match_class! macro #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OddCoincidence merged 3 commits into from
Apr 4, 2019
Merged

Add match_class! macro #774

OddCoincidence merged 3 commits into from
Apr 4, 2019

Conversation

@OddCoincidence
Copy link
Contributor

@OddCoincidence OddCoincidence commented Apr 2, 2019

See #771 for more details and discussion.

coolreader18
coolreader18 approved these changes Apr 2, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Apr 2, 2019 •
edited
Loading

Codecov Report

Merging #774 into master will increase coverage by 1.46%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   62.15%   63.62%   +1.46%     
==========================================
  Files          80       82       +2     
  Lines       12832    13722     +890     
  Branches     2621     2981     +360     
==========================================
+ Hits         7976     8730     +754     
- Misses       3190     3269      +79     
- Partials     1666     1723      +57
Impacted Files Coverage Δ
vm/src/obj/objfloat.rs 74.45% <0%> (-0.83%) ⬇️
vm/src/obj/objstr.rs 78.8% <75%> (+8.2%) ⬆️
vm/src/obj/objint.rs 87.61% <83.33%> (+1.35%) ⬆️
derive/src/from_args.rs 50.54% <0%> (ø)
derive/src/pyclass.rs 54.86% <0%> (ø)
parser/src/parser.rs 91.6% <0%> (+0.18%) ⬆️
vm/src/pyobject.rs 77.3% <0%> (+0.42%) ⬆️
vm/src/vm.rs 72.58% <0%> (+0.7%) ⬆️
vm/src/builtins.rs 66.66% <0%> (+3.03%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce15e1...88bf2a3. Read the comment docs.

@palaviv palaviv mentioned this pull request Apr 3, 2019
Closed
@OddCoincidence OddCoincidence merged commit 1c958c9 into master Apr 4, 2019
@OddCoincidence OddCoincidence deleted the joey/match-class branch April 9, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OddCoincidence @codecov-io @coolreader18