sequence protocol #770
sequence protocol #770
Conversation
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 62.04% 62.17% +0.13%
==========================================
Files 80 80
Lines 12722 12643 -79
Branches 2620 2596 -24
==========================================
- Hits 7893 7861 -32
+ Misses 3159 3122 -37
+ Partials 1670 1660 -10
Continue to review full report at Codecov.
|
| where | ||
| Self: Sized, | ||
| { | ||
| fn get_elements(&self) -> Vec<PyObjectRef>; |
There was a problem hiding this comment.
we definitely don't want to copy the entire vec just to eg check its size.
There was a problem hiding this comment.
Agree. I can't do a Deref inside the trait. Do you have a suggestion for something nicer then returning the Refcell?
There was a problem hiding this comment.
You could try returning an &[PyObjectRef], or if that wouldn't work an impl Deref<Target = [PyObjectRef]>.
| { | ||
| fn get_elements(&self) -> Vec<PyObjectRef>; | ||
| fn as_object(&self) -> &PyObjectRef; | ||
| fn into_object(self) -> PyObjectRef; |
There was a problem hiding this comment.
I think this could be split off into a separate trait, and we could have a generic impl<T> ... for PyRef<T>
|
Should be implemented with inner like #785. |
Same as #765 but for
tupleandlist.