crates/vm/src/stdlib/ctypes/array.rs (1)

434-444: Consider adding bounds check for consistent error messaging.

The Constructor::slot_new (lines 412-414) checks args.args.len() > length and returns a "too many initializers" error. This Initializer relies on setitem_by_index which returns a less descriptive "invalid index" error. While functionally correct, adding the same check would improve consistency.

🔎 Suggested improvement

 impl Initializer for PyCArray {
     type Args = FuncArgs;
 
     fn init(zelf: PyRef<Self>, args: Self::Args, vm: &VirtualMachine) -> PyResult<()> {
+        let length = zelf.class().stg_info_opt().map_or(0, |i| i.length);
+        if args.args.len() > length {
+            return Err(vm.new_index_error("too many initializers"));
+        }
         // Re-initialize array elements when __init__ is called
         for (i, value) in args.args.iter().enumerate() {
             PyCArray::setitem_by_index(&zelf, i as isize, value.clone(), vm)?;
         }
         Ok(())
     }
 }

crates/vm/src/stdlib/ctypes/simple.rs (1)

1300-1313: Inconsistent length handling between Cow::Borrowed and Cow::Owned branches.

The Cow::Borrowed branch uses .min() which silently truncates if buffer lengths differ (line 1305), while Cow::Owned uses copy_from_slice which panics on length mismatch (line 1311).

For simple types the sizes should always match, but this inconsistency could mask bugs. Consider using consistent handling in both branches.

🔎 Suggested fix for consistent behavior

             Cow::Owned(vec) => {
-                vec.copy_from_slice(&buffer_bytes);
+                let len = vec.len().min(buffer_bytes.len());
+                vec[..len].copy_from_slice(&buffer_bytes[..len]);
             }

Or alternatively, add the .min() check to both branches and add an assertion/debug check if sizes unexpectedly differ.

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro